Add per-key backlight off support and fix scroll lock indicator#472
Open
Lord-Memester wants to merge 11 commits into
Open
Add per-key backlight off support and fix scroll lock indicator#472Lord-Memester wants to merge 11 commits into
Lord-Memester wants to merge 11 commits into
Conversation
Lord-Memester
marked this pull request as ready for review
last monthJune 1, 2026 04:11
Author
Also notable:In the main.js for the keychron web configurator tool, line 91171 is as follows: return [w.r, w.g, w.b].some(m => m > 30) || (w[b] = Math.max(30, w[b])),and performing a local override with the following minor change to that same line return [w.r, w.g, w.b].some(m => m > 30) || (w[b] = Math.max(0, w[b])),allows users to set hex #000000 for keys, which is what is required to disable them per-key. |
| hsv.v = rgb_matrix_config.hsv.v; | ||
| // If per-key brightness is 0, keep it off (don't apply global brightness) | ||
| // Otherwise, apply global brightness | ||
| if (per_key_led[i].v > 0) { |
The Apply Global Brightness screws with per-key color values as is, I would recommend either just doing away with the global V entirely in per key mode or multiplying the key specific V by the global V.
|
Thank you! Could someone from the official Keychron team please merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Added support for turning backlight off per-key.
Fixed typos.
Fixed implementation of scroll lock indicator.
Types of Changes
Issues Fixed or Closed by This PR
Checklist