This seems like it is meant for use by document-based apps? That doesn’t seem like it fits very well with what iSH is.

Well. iSH can do a many things. I use it in order to store files (aka 'documents') in a git repository. Given the number of issues related to git, I assume some other people use it for similar reasons. While the UISupportsDocumentBrowser documentation has a top line that it is for 'document based apps', the 'Discussion' area states exacty what it actually does. This is to make the app's Documents folder available to other apps for editing and saving files.

iSH does already provide access to its files through the NSFIleProvider extension, so this might be considered redundant and possibly confusiing, but I know of at least one app (Notebooks) that cannot access the files through the extension, but that can access the files through the 'On my iPhone' option that the UISupportsDocumentBrowser supports.

There are work-arounds for the issue by using a shared folder created in Files and mounting that folder with -t iOS, but that requires use of the file selection UI. Allowing access to the Documents directory avoids that UI.

I'm not sure I understand you: you are intentionally mounting the iSH documents directory via realfs and saving content there?

Yes. But, I'm only doing that so I can get to the files from other apps without using the NSFileProvider extension or the iOS file selection UI.

Using my compiled version of ish with the requested mod to Info.plist, I mount the Documents directory in ish using: mount -t real `cat /proc/ish/documents` /iosdocuments

From other apps, I access these files under "On My iPhone > "iSH"

This is using the standard file picker, right? You're saying that you can see iSH there when you turn this on but not the file provider?

This is using the standard file picker, right?

Yes. This is the Files app and standard file picker in other apps.

You're saying that you can see iSH there when you turn this on but not the file provider?

No. When I turn UISupportsDocumentBrowser on, I can see both. I can see iSH in the On My iPhone area, and I can see the iSH FileProvider in the Locations area. In some apps (like Notebooks & Textastic), though, I am unable to choose folders when using the iSH File Provider because the folders/files are greyed out. Presumably, this is disallowed in those apps because the FileProvider extension doesn't provide capabilities those apps need. When I choose items using the 'On My iPhone' option in those apps, I am allowed to proceed.