Skip to content

WIP: simplify history build#7378

Closed
zblgg wants to merge 0 commit into
TanStack:mainfrom
zblgg:fix/history-package
Closed

WIP: simplify history build#7378
zblgg wants to merge 0 commit into
TanStack:mainfrom
zblgg:fix/history-package

Conversation

@zblgg
Copy link
Copy Markdown

@zblgg zblgg commented May 11, 2026

No description provided.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 11, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 019532f5-8373-4ba5-a5c5-7393f1cd810e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sorry, something went wrong.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 11, 2026

Bundle Size Benchmarks

  • Commit: b1c061aff918
  • Measured at: 2026-05-11T11:31:09.259Z
  • Baseline source: history:b1c061aff918
  • Dashboard: bundle-size history
Scenario Current (gzip) Delta vs baseline Initial gzip Raw Brotli Trend
react-router.minimal 87.29 KiB 0 B (0.00%) 87.15 KiB 274.07 KiB 75.85 KiB ▁▁▁▁▁▁▁▁▁██
react-router.full 90.82 KiB 0 B (0.00%) 90.68 KiB 285.58 KiB 78.89 KiB ▁▁▁▁▁▁▁▁▁██
solid-router.minimal 35.51 KiB 0 B (0.00%) 35.39 KiB 106.36 KiB 31.97 KiB ▁▁▁▁▁▁▁▁▁██
solid-router.full 40.23 KiB 0 B (0.00%) 40.10 KiB 120.58 KiB 36.14 KiB ▁▁▁▁▁▁▁▁▁██
vue-router.minimal 53.29 KiB 0 B (0.00%) 53.15 KiB 151.51 KiB 47.85 KiB ▁▁▁▁▁▁▁▁▁██
vue-router.full 58.41 KiB 0 B (0.00%) 58.28 KiB 167.69 KiB 52.39 KiB ▁▁▁▁▁▁▁▁▁██
react-start.minimal 101.97 KiB 0 B (0.00%) 101.83 KiB 322.51 KiB 88.17 KiB ▁▁▁▁▁▁▁▁▃██
react-start.full 105.41 KiB 0 B (0.00%) 105.27 KiB 332.84 KiB 91.19 KiB ▁▁▁▁▁▁▁▁▄██
react-start.rsbuild.minimal 99.60 KiB 0 B (0.00%) 99.43 KiB 316.97 KiB 85.64 KiB ▁▁▁▁▁▁▁▁▄██
react-start.rsbuild.full 102.89 KiB 0 B (0.00%) 102.72 KiB 327.41 KiB 88.45 KiB ▁▁▁▁▁▁▁▁▃██
solid-start.minimal 49.61 KiB 0 B (0.00%) 49.48 KiB 152.48 KiB 43.78 KiB ▁▁▁▁▁▁▁▁▄██
solid-start.full 55.40 KiB 0 B (0.00%) 55.27 KiB 169.39 KiB 48.72 KiB ▁▁▁▁▁▁▁▁▄██

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

@zblgg zblgg force-pushed the fix/history-package branch from dbdecb4 to 65bf499 Compare May 11, 2026 11:11
@zblgg zblgg closed this May 11, 2026
@zblgg zblgg force-pushed the fix/history-package branch from 65bf499 to b1c061a Compare May 11, 2026 11:31
@zblgg zblgg deleted the fix/history-package branch May 11, 2026 11:31
@anthony-effectual
Copy link
Copy Markdown

sus...

@caretak3r
Copy link
Copy Markdown

Cache lol

@velikopter
Copy link
Copy Markdown

:shipit:

@InvalidPathException
Copy link
Copy Markdown

gigabrained

@viiccwen
This comment was marked as a violation of GitHub Acceptable Use Policies
@nwvh
Copy link
Copy Markdown

nwvh commented May 12, 2026

well played.

@theg1239
Copy link
Copy Markdown

🐛🫩

@mst2k
Copy link
Copy Markdown

mst2k commented May 12, 2026

lgtm

@staz6
Copy link
Copy Markdown

staz6 commented May 12, 2026

WIP xdd

@EverStarck
Copy link
Copy Markdown

ngl this was genius

@awdev1
Copy link
Copy Markdown

awdev1 commented May 12, 2026

Quite the card play here

@borngreat-ikwutah
Copy link
Copy Markdown

wow what a hacker

@RyukTheCoder
Copy link
Copy Markdown

Niceee

@nsnsay
Copy link
Copy Markdown

nsnsay commented May 14, 2026

All unjust hackers family die

@xCirno1
Copy link
Copy Markdown

xCirno1 commented May 15, 2026

Very well performed, never thought about this method

@Gan-Tu
Copy link
Copy Markdown

Gan-Tu commented May 18, 2026

Well done...

@brunoliberal
Copy link
Copy Markdown

LGTM. First time on the job. Excited to review your PR. Easiest review ever!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

None yet