feat: 1000yen gacha#9
Merged
nakasyou merged 3 commits intopnsk-lab:mainfrom May 4, 2026
Merged
Conversation
eff35a5 to
19159f0
Compare
Contributor
Pull request overview
Adds a “1000円ガチャ” feature to the Betterzeriya session ordering page, plus build/runtime wiring to support using server-side menu mock data during development while stubbing it out in production bundles.
Changes:
- Add a gacha UI + selection logic (budgeted random menu picks) and a results dialog on
sessions/[id]. - Introduce
$server-mockaliasing and a production stub JSON to avoid shipping the full server mock menu JSON in production. - Adjust root scripts to add
build/startconveniences and split app dev (dev:app) from server dev.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updates root scripts (dev/app dev, build/start aliases). |
| apps/betterzeriya/vite.config.ts | Adds production-only alias to stub $server-mock/menu.json. |
| apps/betterzeriya/svelte.config.js | Adds $server-mock alias to server data directory. |
| apps/betterzeriya/src/routes/sessions/[id]/+page.svelte | Implements gacha logic/UI and DEV-only initial menu availability via mock state map. |
| apps/betterzeriya/src/routes/layout.css | Adds toolbar + gacha dialog/list styling; adds line-clamp. |
| apps/betterzeriya/src/lib/server-mock-stub.json | Adds an empty JSON stub for production builds. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "type": "module", | ||
| "scripts": { | ||
| "dev": "bun --cwd packages/server --watch src/main.ts", | ||
| "dev": "cd packages/server && bun --watch src/main.ts", |
Copilot commented on May 4, 2026
CopilotAI
Suggested changeset (1)
package.json
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
Copilot uses AI. Check for mistakes.
| "betterzeriya:build": "bun run --cwd packages/client build && bun run --cwd apps/betterzeriya build", | ||
| "betterzeriya:start": "node apps/betterzeriya/build", | ||
| "build": "bun run betterzeriya:build", | ||
| "start": "HOST=localhost node apps/betterzeriya/build", |
Copilot commented on May 4, 2026
CopilotAI
Suggested changeset (1)
package.json
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
| 15 | + | |
| 16 | + | |
16 | 17 | | |
17 | 18 | | |
18 | 19 | | |
Copilot uses AI. Check for mistakes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Why?
1000yen gacha is fun